Steve Reinhardt via gem5-dev
2014-05-14 05:47:05 UTC
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2276/
-----------------------------------------------------------
Review request for Default.
Repository: gem5
Description
-------
Changeset 10228:f377969aa1b2
---------------------------
ruby: don't make O3 CPU squash on loads that hit outstanding requests
Mismatch between O3 and Ruby in handling aliased requests: Ruby
returns false when it sees aliased request or memory blocked. O3
squash and refetch when it sees false signal from Ruby.
Fix: Merging readRequestTable and writeRequestTable in a single table
that maps requesting address and all requests that are aliased with
the address.
This work was done while Binh was an intern at AMD Research.
Diffs
-----
src/mem/ruby/system/Sequencer.hh 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f
src/mem/ruby/system/Sequencer.cc 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f
Diff: http://reviews.gem5.org/r/2276/diff/
Testing
-------
Thanks,
Steve Reinhardt
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2276/
-----------------------------------------------------------
Review request for Default.
Repository: gem5
Description
-------
Changeset 10228:f377969aa1b2
---------------------------
ruby: don't make O3 CPU squash on loads that hit outstanding requests
Mismatch between O3 and Ruby in handling aliased requests: Ruby
returns false when it sees aliased request or memory blocked. O3
squash and refetch when it sees false signal from Ruby.
Fix: Merging readRequestTable and writeRequestTable in a single table
that maps requesting address and all requests that are aliased with
the address.
This work was done while Binh was an intern at AMD Research.
Diffs
-----
src/mem/ruby/system/Sequencer.hh 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f
src/mem/ruby/system/Sequencer.cc 34f48d0dac97d04f3d1e129a1f4aa00d869b1d8f
Diff: http://reviews.gem5.org/r/2276/diff/
Testing
-------
Thanks,
Steve Reinhardt