Change in ovirt-engine[master]: core: Collect vm numa node runtime information

[x***@public.gmane.org]

Xiaolei Shi has uploaded a new change for review.

Change subject: core: Collect vm numa node runtime information
......................................................................

core: Collect vm numa node runtime information

Collect vm numa node runtime pinning to which host numa nodes data.

Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Bug-Url: https://bugzilla.redhat.com/1100202
Signed-off-by: Bruce Shi <xiao-lei.shi-***@public.gmane.org>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/numa_sp.sql
9 files changed, 224 insertions(+), 2 deletions(-)


git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/28096/1

diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
index f747804..a7bb703 100644
--- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
+++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
@@ -1,6 +1,7 @@
package org.ovirt.engine.core.common.businessentities;

import java.util.ArrayList;
+import java.util.List;

import org.ovirt.engine.core.common.businessentities.comparators.BusinessEntityGuidComparator;
import org.ovirt.engine.core.common.businessentities.network.VmNetworkInterface;
@@ -13,6 +14,8 @@
private Double cpu_sysField;
// NOT PERSISTED
private VmBalloonInfo vmBalloonInfo;
+ // NOT PERSISTED
+ private List<VmNumaNode> vNumaNodeStatisticsList;

public VmStatistics() {
cpu_sysField = 0.0;
@@ -20,6 +23,7 @@
elapsed_timeField = 0.0;
roundedElapsedTimeField = 0.0;
vm_guidField = Guid.Empty;
+ vNumaNodeStatisticsList = new ArrayList<VmNumaNode>();
}

@Override
@@ -37,6 +41,7 @@
result = prime * result + ((migrationProgressPercent == null) ? 0 : migrationProgressPercent.hashCode());
result = prime * result + ((disksUsage == null) ? 0 : disksUsage.hashCode());
result = prime * result + ((vm_guidField == null) ? 0 : vm_guidField.hashCode());
+ result = prime * result + ((vNumaNodeStatisticsList == null) ? 0 : vNumaNodeStatisticsList.hashCode());
return result;
}

@@ -62,7 +67,8 @@
&& ObjectUtils.objectsEqual(migrationProgressPercent, other.migrationProgressPercent)
&& ObjectUtils.objectsEqual(usage_network_percentField, other.usage_network_percentField)
&& ObjectUtils.objectsEqual(disksUsage, other.disksUsage)
- && ObjectUtils.objectsEqual(vm_guidField, other.vm_guidField));
+ && ObjectUtils.objectsEqual(vm_guidField, other.vm_guidField)
+ && ObjectUtils.objectsEqual(vNumaNodeStatisticsList, other.vNumaNodeStatisticsList));
}

public Double getcpu_sys() {
@@ -209,4 +215,12 @@
public void setVmBalloonInfo(VmBalloonInfo vmBalloonInfo) {
this.vmBalloonInfo = vmBalloonInfo;
}
+
+ public List<VmNumaNode> getvNumaNodeStatisticsList() {
+ return vNumaNodeStatisticsList;
+ }
+
+ public void setvNumaNodeStatisticsList(List<VmNumaNode> vNumaNodeStatisticsList) {
+ this.vNumaNodeStatisticsList = vNumaNodeStatisticsList;
+ }
}
diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
index 617a885..bd999ff 100644
--- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
+++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
@@ -153,7 +153,7 @@
.addValue("cpu_core_id", cpuId);
}

- private MapSqlParameterSource createVnodeToPnodeParametersMapper(
+ protected MapSqlParameterSource createVnodeToPnodeParametersMapper(
Pair<Guid, Pair<Boolean, Integer>> pNode, Guid vNodeId) {
return getCustomMapSqlParameterSource()
.addValue("id", Guid.newGuid())
diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java
index 4dffbf9..3505562 100644
--- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java
+++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java
@@ -49,4 +49,13 @@
*/
List<Pair<Guid, Integer>> getPinnedNumaNodeIndex(Guid vmId);

+ /**
+ * Update vm numa node runtime pinning data of the given list of numa nodes using a more
+ * efficient method to update all of them at once, rather than each at a time.
+ *
+ * @param vmNumaNodes
+ * the vm numa nodes to be updated
+ */
+ void massUpdateVmNumaNodeRuntimePinning(List<VmNumaNode> vmNumaNodes);
+
}
diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
index cb3d5ee..3b951a7 100644
--- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
+++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
@@ -232,4 +232,18 @@
vNodePinToPnodeRowMapper, parameterSource);
}

+ @Override
+ public void massUpdateVmNumaNodeRuntimePinning(List<VmNumaNode> vmNumaNodes) {
+ List<MapSqlParameterSource> vNodeToPnodeDeletions = new ArrayList<>();
+ List<MapSqlParameterSource> vNodeToPnodeInsertions = new ArrayList<>();
+ for (VmNumaNode node : vmNumaNodes) {
+ vNodeToPnodeDeletions.add(getCustomMapSqlParameterSource().addValue("vm_numa_node_id", node.getId()));
+ for (Pair<Guid, Pair<Boolean, Integer>> pair : node.getVdsNumaNodeList()) {
+ vNodeToPnodeInsertions.add(createVnodeToPnodeParametersMapper(pair, node.getId()));
+ }
+ }
+ getCallsHandler().executeStoredProcAsBatch("DeleteUnpinnedNumaNodeMapByVmNumaNodeId", vNodeToPnodeDeletions);
+ getCallsHandler().executeStoredProcAsBatch("InsertNumaNodeMap", vNodeToPnodeInsertions);
+ }
+
}
diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java
index f524604..4256294 100644
--- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java
+++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java
@@ -267,6 +267,88 @@
assertEquals(0, result.size());
}

+ @Test
+ public void testMassUpdateVmNumaNodeRuntimePinning() {
+ List<VmNumaNode> result = vmNumaNodeDao.getAllVmNumaNodeByVmId(ANOTHER_EXISTING_VM_ID);
+ assertNotNull(result);
+ assertEquals(0, result.size());
+
+ Guid vdsNumaNode1 = new Guid("3c2b81e6-5080-4ad1-86a1-cf513b15b515");
+ Guid vdsNumaNode2 = new Guid("3c2b81e6-5080-4ad1-86a1-cf513b15b516");
+ Guid vmNumaNode1 = Guid.newGuid();
+ Guid vmNumaNode2 = Guid.newGuid();
+
+ List<VdsNumaNode> newVmNode = new ArrayList<>();
+ VmNumaNode newVmNumaNode = new VmNumaNode();
+ newVmNumaNode.setCpuIds(generateCpuList(0, 4));
+ newVmNumaNode.setId(vmNumaNode1);
+ newVmNumaNode.setIndex(0);
+ newVmNumaNode.setNumaNodeDistances(generateDistance(2, 0));
+ newVmNumaNode.setNumaNodeStatistics(newNodeStatistics);
+ newVmNumaNode.getVdsNumaNodeList().add(new Pair<>(vdsNumaNode1, new Pair<>(false, 0)));
+ newVmNode.add(newVmNumaNode);
+
+ newVmNumaNode = new VmNumaNode();
+ newVmNumaNode.setCpuIds(generateCpuList(4, 4));
+ newVmNumaNode.setId(vmNumaNode2);
+ newVmNumaNode.setIndex(1);
+ newVmNumaNode.setNumaNodeDistances(generateDistance(2, 1));
+ newVmNumaNode.setNumaNodeStatistics(newNodeStatistics);
+ newVmNumaNode.getVdsNumaNodeList().add(new Pair<>(vdsNumaNode2, new Pair<>(false, 1)));
+ newVmNode.add(newVmNumaNode);
+
+ vmNumaNodeDao.massSaveNumaNode(newVmNode, null, ANOTHER_EXISTING_VM_ID);
+ result = vmNumaNodeDao.getAllVmNumaNodeByVmId(ANOTHER_EXISTING_VM_ID);
+ assertNotNull(result);
+ assertEquals(2, result.size());
+
+ Map<Guid, VmNumaNode> nodes = new HashMap<>(2);
+ nodes.put(result.get(0).getId(), result.get(0));
+ nodes.put(result.get(1).getId(), result.get(1));
+
+ nodes.get(vmNumaNode1).getVdsNumaNodeList().clear();
+ nodes.get(vmNumaNode1).getVdsNumaNodeList().add(new Pair<>(vdsNumaNode2, new Pair<>(false, 1)));
+
+ nodes.get(vmNumaNode2).getVdsNumaNodeList().clear();
+ nodes.get(vmNumaNode2).getVdsNumaNodeList().add(new Pair<>(vdsNumaNode1, new Pair<>(false, 0)));
+
+ List<VmNumaNode> updateNodes = new ArrayList<>();
+ updateNodes.add(nodes.get(vmNumaNode1));
+ updateNodes.add(nodes.get(vmNumaNode2));
+
+ vmNumaNodeDao.massUpdateVmNumaNodeRuntimePinning(updateNodes);
+
+ result = vmNumaNodeDao.getAllVmNumaNodeByVmId(ANOTHER_EXISTING_VM_ID);
+ assertNotNull(result);
+ assertEquals(2, result.size());
+
+ nodes.clear();
+ nodes.put(result.get(0).getId(), result.get(0));
+ nodes.put(result.get(1).getId(), result.get(1));
+
+ assertTrue(nodes.containsKey(vmNumaNode1));
+ assertTrue(nodes.containsKey(vmNumaNode2));
+
+ assertEquals(1, nodes.get(vmNumaNode1).getVdsNumaNodeList().size());
+ assertEquals(false, nodes.get(vmNumaNode1).getVdsNumaNodeList().get(0).getSecond().getFirst());
+ assertEquals(vdsNumaNode2, nodes.get(vmNumaNode1).getVdsNumaNodeList().get(0).getFirst());
+ assertEquals(1, nodes.get(vmNumaNode1).getVdsNumaNodeList().get(0).getSecond().getSecond().intValue());
+
+ assertEquals(1, nodes.get(vmNumaNode2).getVdsNumaNodeList().size());
+ assertEquals(false, nodes.get(vmNumaNode2).getVdsNumaNodeList().get(0).getSecond().getFirst());
+ assertEquals(vdsNumaNode1, nodes.get(vmNumaNode2).getVdsNumaNodeList().get(0).getFirst());
+ assertEquals(0, nodes.get(vmNumaNode2).getVdsNumaNodeList().get(0).getSecond().getSecond().intValue());
+
+ List<Guid> vmNodeList = new ArrayList<Guid>();
+ vmNodeList.add(vmNumaNode1);
+ vmNodeList.add(vmNumaNode2);
+ vmNumaNodeDao.massRemoveNumaNodeByNumaNodeId(vmNodeList);
+
+ result = vmNumaNodeDao.getAllVmNumaNodeByVmId(ANOTHER_EXISTING_VM_ID);
+ assertNotNull(result);
+ assertEquals(0, result.size());
+ }
+
private List<Integer> generateCpuList(int fromIndex, int count) {
List<Integer> cpuList = new ArrayList<>(count);
for (int i = fromIndex; i < (fromIndex + count); i++) {
diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
index 5a7f128..5ad3d4a 100644
--- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
+++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
@@ -47,6 +47,7 @@
import org.ovirt.engine.core.common.businessentities.VmExitReason;
import org.ovirt.engine.core.common.businessentities.VmExitStatus;
import org.ovirt.engine.core.common.businessentities.VmGuestAgentInterface;
+import org.ovirt.engine.core.common.businessentities.VmNumaNode;
import org.ovirt.engine.core.common.businessentities.VmPauseStatus;
import org.ovirt.engine.core.common.businessentities.VmStatic;
import org.ovirt.engine.core.common.businessentities.VmStatistics;
@@ -75,6 +76,7 @@
import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector;
import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase;
import org.ovirt.engine.core.utils.NetworkUtils;
+import org.ovirt.engine.core.utils.NumaUtils;
import org.ovirt.engine.core.utils.ObjectIdentityChecker;
import org.ovirt.engine.core.utils.log.Log;
import org.ovirt.engine.core.utils.log.LogFactory;
@@ -194,7 +196,27 @@
getDbFacade().getLunDao().updateAllInBatch(vmLunDisksToSave);
saveVmDevicesToDb();
saveVmGuestAgentNetworkDevices();
+ saveVmNumaNodeRuntimeData();
getVdsEventListener().addExternallyManagedVms(_externalVmsToAdd);
+ }
+
+ private void saveVmNumaNodeRuntimeData() {
+ if (!_vmStatisticsToSave.isEmpty()) {
+ final List<VmNumaNode> vmNumaNodesToUpdate = new ArrayList<>();
+ for(VmStatistics vmStats : _vmStatisticsToSave.values()) {
+ vmNumaNodesToUpdate.addAll(vmStats.getvNumaNodeStatisticsList());
+ }
+ if (!vmNumaNodesToUpdate.isEmpty()) {
+ TransactionSupport.executeInScope(TransactionScopeOption.Required,
+ new TransactionMethod<Void>() {
+ @Override
+ public Void runInTransaction() {
+ getDbFacade().getVmNumaNodeDAO().massUpdateVmNumaNodeRuntimePinning(vmNumaNodesToUpdate);
+ return null;
+ }
+ });
+ }
+ }
}

private void saveVmGuestAgentNetworkDevices() {
@@ -1960,6 +1982,7 @@
if (_vdsManager.getRefreshStatistics()) {
VmStatistics vmStatistics = _runningVms.get(vmToUpdate.getId()).getVmStatistics();
vmToUpdate.updateRunTimeStatisticsData(vmStatistics, vmToUpdate);
+ updateVmNumaNodeRuntimeInfo(vmStatistics, vmToUpdate);
addVmStatisticsToList(vmToUpdate.getStatisticsData());
updateInterfaceStatistics(vmToUpdate, vmStatistics);

@@ -1978,6 +2001,44 @@
}
}

+ private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
+ if (vm.getRunOnVds() == null) {
+ return;
+ }
+ List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds());
+ List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId());
+ Map<Integer, VdsNumaNode> runOnVdsAllNumaNodesMap = new HashMap<>();
+ Map<Integer, VmNumaNode> vmAllNumaNodesMap = new HashMap<>();
+ for (VdsNumaNode vdsNumaNode : runOnVdsAllNumaNodes) {
+ runOnVdsAllNumaNodesMap.put(vdsNumaNode.getIndex(), vdsNumaNode);
+ }
+ for (VmNumaNode vmNumaNode : vmAllNumaNodes) {
+ vmAllNumaNodesMap.put(vmNumaNode.getIndex(), vmNumaNode);
+ }
+ List<VmNumaNode> vmNumaNodesNeedUpdate = new ArrayList<>();
+ for (VmNumaNode vNode : statistics.getvNumaNodeStatisticsList()) {
+ VmNumaNode dbVmNumaNode = vmAllNumaNodesMap.get(vNode.getIndex());
+ if (dbVmNumaNode != null) {
+ vNode.setId(dbVmNumaNode.getId());
+ List<Integer> pinnedNodes = NumaUtils.getPinnedNodeIndexList(dbVmNumaNode.getVdsNumaNodeList());
+ List<Pair<Guid, Pair<Boolean, Integer>>> runTimePinList = new ArrayList<>();
+ for (Pair<Guid, Pair<Boolean, Integer>> pair : vNode.getVdsNumaNodeList()){
+ if ((!pinnedNodes.contains(pair.getSecond().getSecond())) &&
+ (runOnVdsAllNumaNodesMap.containsKey(pair.getSecond().getSecond()))) {
+ pair.setFirst(runOnVdsAllNumaNodesMap.get(pair.getSecond().getSecond()).getId());
+ pair.getSecond().setFirst(false);
+ runTimePinList.add(pair);
+ }
+ }
+ vNode.setVdsNumaNodeList(runTimePinList);
+ if (!vNode.getVdsNumaNodeList().isEmpty()) {
+ vmNumaNodesNeedUpdate.add(vNode);
+ }
+ }
+ }
+ vm.getStatisticsData().getvNumaNodeStatisticsList().addAll(vmNumaNodesNeedUpdate);
+ }
+
private void updateInterfaceStatistics(VM vm, VmStatistics statistics) {
if (statistics.getInterfaceStatistics() == null) {
return;
diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
index 3a2950e..6d7e9e0 100644
--- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
+++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
@@ -40,6 +40,7 @@
import org.ovirt.engine.core.common.businessentities.VmExitReason;
import org.ovirt.engine.core.common.businessentities.VmExitStatus;
import org.ovirt.engine.core.common.businessentities.VmGuestAgentInterface;
+import org.ovirt.engine.core.common.businessentities.VmNumaNode;
import org.ovirt.engine.core.common.businessentities.VmPauseStatus;
import org.ovirt.engine.core.common.businessentities.VmStatistics;
import org.ovirt.engine.core.common.businessentities.network.InterfaceStatus;
@@ -52,6 +53,7 @@
import org.ovirt.engine.core.common.config.Config;
import org.ovirt.engine.core.common.config.ConfigValues;
import org.ovirt.engine.core.common.utils.EnumUtils;
+import org.ovirt.engine.core.common.utils.Pair;
import org.ovirt.engine.core.common.utils.SizeConverter;
import org.ovirt.engine.core.compat.Guid;
import org.ovirt.engine.core.compat.RpmVersion;
@@ -362,6 +364,11 @@
// ------------- vm migration statistics -----------------------
Integer migrationProgress = AssignIntValue(xmlRpcStruct, VdsProperties.vm_migration_progress_percent);
vm.setMigrationProgressPercent(migrationProgress != null ? migrationProgress : 0);
+
+ // ------------- vm numa nodes runtime info -------------------------
+ if (xmlRpcStruct.containsKey(VdsProperties.VM_NUMA_NODES_RUNTIME_INFO)) {
+ updateVmNumaNodesRuntimeInfo(vm, xmlRpcStruct);
+ }
}

private static VmBalloonInfo getBalloonInfo(Map<String, Object> xmlRpcStruct) {
@@ -1593,6 +1600,25 @@

}

+ /**
+ * Build through the received vm NUMA nodes runtime information
+ * @param vm
+ * @param xmlRpcStruct
+ */
+ private static void updateVmNumaNodesRuntimeInfo(VmStatistics vm, Map<String, Object> xmlRpcStruct) {
+ Map<String, Object[]> vNodesRunInfo = (Map<String, Object[]>)xmlRpcStruct.get(
+ VdsProperties.VM_NUMA_NODES_RUNTIME_INFO);
+ for (Map.Entry<String, Object[]> item : vNodesRunInfo.entrySet()) {
+ VmNumaNode vNode = new VmNumaNode();
+ vNode.setIndex(Integer.valueOf(item.getKey()));
+ for (Object pNodeIndex : item.getValue()) {
+ vNode.getVdsNumaNodeList().add(new Pair<>(
+ Guid.Empty, new Pair<>(false, (Integer)pNodeIndex)));
+ }
+ vm.getvNumaNodeStatisticsList().add(vNode);
+ }
+ }
+
private static List<String> extracStringtList(Map<String, Object> xmlRpcStruct, String propertyName) {
if (!xmlRpcStruct.containsKey(propertyName)){
return null;
diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
index e469c36..ed3b1d1 100644
--- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
+++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
@@ -101,6 +101,7 @@
public static final String VM_NUMA_NODE_MEM = "memory";
public static final String NUMA_TUNE = "numaTune";
public static final String VM_NUMA_NODES = "guestNumaNodes";
+ public static final String VM_NUMA_NODES_RUNTIME_INFO = "vNodeRuntimeInfo";

// Network related properties
public static final String NETWORK = "network";
diff --git a/packaging/dbscripts/numa_sp.sql b/packaging/dbscripts/numa_sp.sql
index 152c070..0e4ad88 100644
--- a/packaging/dbscripts/numa_sp.sql
+++ b/packaging/dbscripts/numa_sp.sql
@@ -267,6 +267,21 @@



+Create or replace FUNCTION DeleteUnpinnedNumaNodeMapByVmNumaNodeId(v_vm_numa_node_id UUID)
+RETURNS VOID
+ AS $procedure$
+BEGIN
+ BEGIN
+ DELETE FROM vm_vds_numa_node_map
+ WHERE vm_numa_node_id = v_vm_numa_node_id AND is_pinned = FALSE;
+ END;
+
+ RETURN;
+END; $procedure$
+LANGUAGE plpgsql;
+
+
+
----------------------------------------------------------------
-- [numa_node_cpus_view] View
--
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 1:

* #1100202::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 1:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/8944/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1042/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/2029/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8261/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25187/ : There was an infra issue, please contact infra-***@public.gmane.org

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2581/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/2470/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 2:

* #1100202::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 2:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9132/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25376/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1088/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2632/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8450/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/2085/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/2512/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 3:

* #1100202::Update tracker: OK
* Bug-Url: IGNORE, not in a monitored branch (ovirt-engine-3.4
* Check merged to previous: IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 3:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/8993/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2756/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9674/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25888/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/2236/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/2632/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1208/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28096/3//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-06-04 12:28:29 +0800
Line 6:
Line 7: core: Collect vm numa node runtime information
Line 8:
Line 9: Collect vm numa node runtime pinning to which host numa nodes data.
please extend comment.
Line 10:
Line 11: Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Line 12: Bug-Url: https://bugzilla.redhat.com/1100202
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/28096/3//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-06-04 12:28:29 +0800
Line 6:
Line 7: core: Collect vm numa node runtime information
Line 8:
Line 9: Collect vm numa node runtime pinning to which host numa nodes data.

Post by gchaplik-H+wXaHxf7aLQT0dZR+
please extend comment.

Done
Line 10:
Line 11: Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Line 12: Bug-Url: https://bugzilla.redhat.com/1100202
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 4:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 4:

Build Failed

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/9063/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2775/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/9744/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/25958/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/2257/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/2649/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1225/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 5:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 5:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/9602/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/2941/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/26496/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/2465/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/2764/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1340/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/10288/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 7:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 7:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3177/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1753/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12481/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3647/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3092/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13152/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29352/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/31/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 8:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 8:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3190/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1766/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12578/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3668/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3107/ : There was an infra issue, please contact infra-***@public.gmane.org

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13247/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29447/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/44/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3193/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.4_update_db_to_master_gerrit/1769/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12596/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3672/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3110/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13265/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29465/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/47/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oourfali-H+wXaHxf7aLQT0dZR+]

Oved Ourfali has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

(1 comment)

Eli - please review DB-related code.

http://gerrit.ovirt.org/#/c/28096/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 2074: }
Line 2075: }
Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {
I'd split this method to sub-methods, or arrange it a bit different, as it is mixed up.

For example, you can start with retrieving, initializing and setting of runOnVdsAllNumaNodes and runOnVdsAllNumaNodesMap and then retrieve, initialize and set vmAllNumaNodes and vmAllNumaNodesMap.

Also, add some spacing here.

And some comments won't hurt as well.
Line 2079: return;
Line 2080: }
Line 2081: List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds());
Line 2082: List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId());
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[emesika-H+wXaHxf7aLQT0dZR+]

Eli Mesika has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/28096/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 2074: }
Line 2075: }
Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {

Post by oourfali-H+wXaHxf7aLQT0dZR+
I'd split this method to sub-methods, or arrange it a bit different, as it

Done
Line 2079: return;
Line 2080: }
Line 2081: List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds());
Line 2082: List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId());
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10: Code-Review-1 Verified-1

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3231/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12818/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3161/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13470/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29670/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/89/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3721/ : FAILURE
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10:

Build Unstable

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3242/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/12874/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3174/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13525/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29725/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/100/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3736/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10:

Build Unstable

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3290/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29902/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/148/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3804/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13702/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3222/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/13051/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oourfali-H+wXaHxf7aLQT0dZR+]

Oved Ourfali has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.4 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3304/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/29976/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/162/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3826/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13776/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3235/ : The patch does not pass the tests

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/13125/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11: -Code-Review -Verified

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3324/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/30082/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/182/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/3857/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/13882/ : FAILURE

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3266/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/13233/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[emesika-H+wXaHxf7aLQT0dZR+]

Eli Mesika has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11: Code-Review-1

(2 comments)

setting -1 for visibility.

http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java:

Line 15: private List<VmJob> vmJobs;
Line 16: // NOT PERSISTED
Line 17: private VmBalloonInfo vmBalloonInfo;
Line 18: // NOT PERSISTED
Line 19: private List<VmNumaNode> vNumaNodeStatisticsList;
why you're not using existing VmNumaNode?
Line 20:
Line 21: public VmStatistics() {
Line 22: cpu_sysField = 0.0;
Line 23: cpu_userField = 0.0;


http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 2074: }
Line 2075: }
Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {
question: incase VM is going down, what will clean the stats?
Line 2079: return;
Line 2080: }
Line 2081:
Line 2082: //Build numa nodes map of the host which the vm is running on with node index as the key
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 12:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 11:

(2 comments)

http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java:

Line 15: private List<VmJob> vmJobs;
Line 16: // NOT PERSISTED
Line 17: private VmBalloonInfo vmBalloonInfo;
Line 18: // NOT PERSISTED
Line 19: private List<VmNumaNode> vNumaNodeStatisticsList;

Post by gchaplik-H+wXaHxf7aLQT0dZR+
why you're not using existing VmNumaNode?

Because in refreshing vm stats process, the vm stats data will be hold in the object VmInternalData(see GetAllVmStatsVDSCommand). The existing VmNumaNode is in VmStatic, but the VmInternalData only contains VmStatistics. So we need to add a field here to hold the numa node runtime stats.
Line 20:
Line 21: public VmStatistics() {
Line 22: cpu_sysField = 0.0;
Line 23: cpu_userField = 0.0;


http://gerrit.ovirt.org/#/c/28096/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 2074: }
Line 2075: }
Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {

Post by gchaplik-H+wXaHxf7aLQT0dZR+
question: incase VM is going down, what will clean the stats?

I checked the action of vm statistics data, that when vm is in powering down state, all the statistics data is still in db; when vm is in down state, all the statistics data will be reset.
So i will follow this action to clean vm numa node runtime info, when vm is down, the runtime pinning data will be removed in db.
Line 2079: return;
Line 2080: }
Line 2081:
Line 2082: //Build numa nodes map of the host which the vm is running on with node index as the key
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 12:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/30925/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3490/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/14091/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/348/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/14725/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3485/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4112/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 13:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 13:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3839/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4707/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16118/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/697/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32925/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16725/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3968/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 13: Code-Review-1

(3 comments)

Some code missing from the previous patch set. I don't know if it caused by the rebase. But it will cause some functionality error. Please hava a check.

http://gerrit.ovirt.org/#/c/28096/13/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java:

Line 238: List<MapSqlParameterSource> vNodeToPnodeInsertions = new ArrayList<>();
Line 239: for (VmNumaNode node : vmNumaNodes) {
Line 240: vNodeToPnodeDeletions.add(getCustomMapSqlParameterSource().addValue("vm_numa_node_id", node.getId()));
Line 241: for (Pair<Guid, Pair<Boolean, Integer>> pair : node.getVdsNumaNodeList()) {
Line 242: vNodeToPnodeInsertions.add(createVnodeToPnodeParametersMapper(pair, node.getId()));
The parameter vmNumaNodes will also contain the pinned nodes statistics data. Need to filter out these data, or else there will be duplicated running info in db.
Please refer to the previous patch set.
Line 243: }
Line 244: }
Line 245: getCallsHandler().executeStoredProcAsBatch("DeleteUnpinnedNumaNodeMapByVmNumaNodeId", vNodeToPnodeDeletions);
Line 246: getCallsHandler().executeStoredProcAsBatch("InsertNumaNodeMap", vNodeToPnodeInsertions);


Line 242: vNodeToPnodeInsertions.add(createVnodeToPnodeParametersMapper(pair, node.getId()));
Line 243: }
Line 244: }
Line 245: getCallsHandler().executeStoredProcAsBatch("DeleteUnpinnedNumaNodeMapByVmNumaNodeId", vNodeToPnodeDeletions);
Line 246: getCallsHandler().executeStoredProcAsBatch("InsertNumaNodeMap", vNodeToPnodeInsertions);
The same as above. Please refer to the previous patch set.
Line 247: }
Line 248:


http://gerrit.ovirt.org/#/c/28096/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 2075: }
Line 2076: }
Line 2077:
Line 2078: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2079: if (vm.getRunOnVds() == null) {
Missing codes. Please refer to the previous patch set.
Line 2080: return;
Line 2081: }
Line 2082:
Line 2083: //Build numa nodes map of the host which the vm is running on with node index as the key
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 14:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 14:

Bruce, missed you've uploaded another patch, replaced them.
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 14:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3844/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4718/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16158/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/702/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/32965/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16765/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/3973/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[x***@public.gmane.org]

Xiaolei Shi has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 14: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 15:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[rgolan-H+wXaHxf7aLQT0dZR+]

Roy Golan has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.ovirt.org/#/c/28096/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 210: final List<VmNumaNode> vmNumaNodesToUpdate = new ArrayList<>();
Line 211: for(VmStatistics vmStats : _vmStatisticsToSave.values()) {
Line 212: vmNumaNodesToUpdate.addAll(vmStats.getvNumaNodeStatisticsList());
Line 213: }
Line 214: if (!vmNumaNodesToUpdate.isEmpty()) {
new TX on monitoring needs a very good reason.

please remove the new TX
Line 215: TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 216: new TransactionMethod<Void>() {
Line 217: @Override
Line 218: public Void runInTransaction() {


Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {
Line 2079: return;
Line 2080: }
do we have to save these numa stats on any VM status?
is it important on anything other than UP status?

this will safe redundant db calls.
Line 2081: List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds());
Line 2082: List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId());
Line 2083: Map<Integer, VdsNumaNode> runOnVdsAllNumaNodesMap = new HashMap<>();
Line 2084: Map<Integer, VmNumaNode> vmAllNumaNodesMap = new HashMap<>();


Line 2102: pair.getSecond().setFirst(false);
Line 2103: runTimePinList.add(pair);
Line 2104: }
Line 2105: }
Line 2106: vNode.setVdsNumaNodeList(runTimePinList);
confusing a bit

maybe:
if (!runTimePinList.isEmpty()) {
vNode.setVdsNumaNodeList(runTimePinList)
vmNumaNodesNeedUpdate.add(vNode)
}
Line 2107: if (!vNode.getVdsNumaNodeList().isEmpty()) {
Line 2108: vmNumaNodesNeedUpdate.add(vNode);
Line 2109: }
Line 2110: }
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 15:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3863/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4763/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16337/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/721/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33143/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16943/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4009/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 9:

(3 comments)

http://gerrit.ovirt.org/#/c/28096/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java:

Line 210: final List<VmNumaNode> vmNumaNodesToUpdate = new ArrayList<>();
Line 211: for(VmStatistics vmStats : _vmStatisticsToSave.values()) {
Line 212: vmNumaNodesToUpdate.addAll(vmStats.getvNumaNodeStatisticsList());
Line 213: }
Line 214: if (!vmNumaNodesToUpdate.isEmpty()) {

Post by rgolan-H+wXaHxf7aLQT0dZR+
new TX on monitoring needs a very good reason.

Done
Line 215: TransactionSupport.executeInScope(TransactionScopeOption.Required,
Line 216: new TransactionMethod<Void>() {
Line 217: @Override
Line 218: public Void runInTransaction() {


Line 2076:
Line 2077: private void updateVmNumaNodeRuntimeInfo(VmStatistics statistics, VM vm) {
Line 2078: if (vm.getRunOnVds() == null) {
Line 2079: return;
Line 2080: }

Post by rgolan-H+wXaHxf7aLQT0dZR+
do we have to save these numa stats on any VM status?

will change line 2078 to check if status is running.
Line 2081: List<VdsNumaNode> runOnVdsAllNumaNodes = getDbFacade().getVdsNumaNodeDAO().getAllVdsNumaNodeByVdsId(vm.getRunOnVds());
Line 2082: List<VmNumaNode> vmAllNumaNodes = getDbFacade().getVmNumaNodeDAO().getAllVmNumaNodeByVmId(vm.getId());
Line 2083: Map<Integer, VdsNumaNode> runOnVdsAllNumaNodesMap = new HashMap<>();
Line 2084: Map<Integer, VmNumaNode> vmAllNumaNodesMap = new HashMap<>();


Line 2102: pair.getSecond().setFirst(false);
Line 2103: runTimePinList.add(pair);
Line 2104: }
Line 2105: }
Line 2106: vNode.setVdsNumaNodeList(runTimePinList);

Post by rgolan-H+wXaHxf7aLQT0dZR+
confusing a bit

Done
Line 2107: if (!vNode.getVdsNumaNodeList().isEmpty()) {
Line 2108: vmNumaNodesNeedUpdate.add(vNode);
Line 2109: }
Line 2110: }
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 16:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 16:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3869/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4772/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16359/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/727/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33165/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/16965/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4017/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 17:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 17:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3883/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4815/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16472/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/741/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33277/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17077/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4038/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[rgolan-H+wXaHxf7aLQT0dZR+]

Roy Golan has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 17: Code-Review+2

please verify
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 18:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 18: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 18:

Build Successful

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3893/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4859/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16644/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/751/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33448/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17248/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4054/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[rgolan-H+wXaHxf7aLQT0dZR+]

Roy Golan has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19:

* Update tracker::#1100202::OK
* Check Bug-Url::OK
* Check Public Bug::#1100202::OK, public bug
* Check Product::#1100202::OK, Correct product oVirt
* Check TR::SKIP, not in a monitored branch (ovirt-engine-3.5 ovirt-engine-3.4 ovirt-engine-3.3 engine_3.2 engine_3.1 ovirt-engine-3.4.0 ovirt-engine-3.3.4 ovirt-engine-3.3.3 ovirt-engine-3.3.2 ovirt-engine-3.3.1)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-engine-3.5', 'ovirt-engine-3.4', 'ovirt-engine-3.3', 'ovirt-engine-3.4.0', 'ovirt-engine-3.3.4', 'ovirt-engine-3.3.3', 'ovirt-engine-3.3.2', 'ovirt-engine-3.3.1'])
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[gchaplik-H+wXaHxf7aLQT0dZR+]

Gilad Chaplik has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[rgolan-H+wXaHxf7aLQT0dZR+]

Roy Golan has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[rgolan-H+wXaHxf7aLQT0dZR+]

Roy Golan has submitted this change and it was merged.

Change subject: core: Collect vm numa node runtime information
......................................................................


core: Collect vm numa node runtime information

Collect vm numa node runtime pinning to which host numa nodes data.
This information is calculated in vdsm according to each vcpu pinning
to which physical cpu core and the process(vcpu) consumed memory
mapping to which host numa nodes.
The reported message format from vdsm is:
'vNodeRuntimeInfo': {'<vmNodeIndex>': [<hostNodeIndex>], ...}

Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Bug-Url: https://bugzilla.redhat.com/1100202
Signed-off-by: Bruce Shi <xiao-lei.shi-***@public.gmane.org>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNumaNodeDAOTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/numa_sp.sql
11 files changed, 239 insertions(+), 2 deletions(-)

Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server

[a***@public.gmane.org]

automation-***@public.gmane.org has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19:

* Update tracker::#1100202::OK
* Check TR::#1100202::ERROR, 3.5.0 should not match .*
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19:

Build Failed

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3897/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao_unit_tests_gerrit/4874/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/16696/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/755/ : FAILURE

http://jenkins.ovirt.org/job/ovirt_engine_master_compile_checkstyle_gerrit/33499/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_gerrit/17299/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_gerrit/4067/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No

[oVirt Jenkins CI Server]

oVirt Jenkins CI Server has posted comments on this change.

Change subject: core: Collect vm numa node runtime information
......................................................................


Patch Set 19:

Build Successful

http://jenkins.ovirt.org/job/ovirt-engine_master_animal-sniffer_merged/8513/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_master_update_db_to_master_gerrit/3899/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt_engine_3.5_update_db_to_master_gerrit/757/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_merged/9566/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_unit-tests_merged/9233/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_create-rpms-quick_merged/4284/ : SUCCESS

http://jenkins.ovirt.org/job/ovirt-engine_master_dao-unit-tests_merged/8891/ : SUCCESS
--
To view, visit http://gerrit.ovirt.org/28096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d2c1dd03e0cc2f7d0ed9593e6ff889712894ac7
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: Arik Hadas <ahadas-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Eli Mesika <emesika-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Gilad Chaplik <gchaplik-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Omer Frenkel <ofrenkel-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Oved Ourfali <oourfali-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Roy Golan <rgolan-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Shahar Havivi <shavivi-H+wXaHxf7aLQT0dZR+***@public.gmane.org>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi-***@public.gmane.org>
Gerrit-Reviewer: automation-***@public.gmane.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No