Code Review
2017-08-07 10:14:34 UTC
From Dan Kenigsberg <***@redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/80194/1/lib/vdsm/api/vdsm-api.yml
File lib/vdsm/api/vdsm-api.yml:
PS1, Line 692: 4.2
--
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report lldp through new getLldp command
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/80194/1/lib/vdsm/api/vdsm-api.yml
File lib/vdsm/api/vdsm-api.yml:
PS1, Line 692: 4.2
Dear reviewer,
too bad Piotr is away, but I think that 4.1.5 is not a valid value here. IMHO since we sneak this API change to 4.1 clusters, we should put 4.1 here and in master as well.--
To view, visit https://gerrit.ovirt.org/80194
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5e81cfbfe9c714d8173ecd6ee20f8b59bd14fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <***@redhat.com>
Gerrit-Reviewer: Dominik Holler <***@redhat.com>
Gerrit-Reviewer: Edward Haas <***@redhat.com>
Gerrit-Reviewer: Irit Goihman <***@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <***@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <***@gmail.com>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list -- vdsm-***@lists.fedorahosted.org
To unsubscribe send an email