[Discover] [Bug 389717] New: Settings page: move toolbar items elsewhere and replace with page name

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

Bug ID: 389717
Summary: Settings page: move toolbar items elsewhere and
replace with page name
Product: Discover
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: discover
Assignee: ***@kde.org
Reporter: ***@zoho.com
Target Milestone: ---

That would be a more centrally-located place for it anyway, and would get rid
of the issue of the Settings page having only one "real" item on its toolbar.

Then, we can move the "Check for Updates" button into the Updates page.

With that done, the now-empty toolbar on the settings page can contain the page
nameu as header text. And maybe as a part of that, we could consider changing
the page name from "Settings" to "Software Sources"

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

--- Comment #1 from Nate Graham <***@zoho.com> ---
Or if putting the Help menu on the sidebar is too awful: here's a radical
thought: actually have a real menubar on the top of the window, at least in
Desktop mode. People keep complaining that Discover looks too much like a
mobile app while in Desktop mode. This might help, and could be a good place to
hide some of the advanced and infrequently used functionality that we seem to
persistently have a hard time placing.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

Nate Graham <***@zoho.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |390347
Summary|Settings page: move toolbar |Settings page: rename to be
|items elsewhere and replace |"Sources" and put the page
|with page name |title in the header


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=390347
[Bug 390347] Move "Check For Updates" button onto Updates page, and only show
it when there are no updates

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

Nate Graham <***@zoho.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |390349


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=390349
[Bug 390349] Move "Help" menu onto the GlobalDrawer (orsome other
globally-available location) with an appropriate UI

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=389717
Bug 389717 depends on bug 390347, which changed state.

Bug 390347 Summary: Move "Check For Updates" button onto Updates page, and only show it in Desktop mode when there are no updates
https://bugs.kde.org/show_bug.cgi?id=390347

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

--- Comment #2 from Nate Graham <***@kde.org> ---
Maybe we can do this even without Bug 390349 once
https://phabricator.kde.org/D10475 lands and Kirigami supports titles on
toolbars with context items?

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=389717
Bug 389717 depends on bug 390349, which changed state.

Bug 390349 Summary: Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI
https://bugs.kde.org/show_bug.cgi?id=390349

What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=389717

Aleix Pol <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/dis
| |cover/b446d7e23123c6c50d19f
| |1ec72b5a291229da045
Status|REPORTED |RESOLVED

--- Comment #3 from Aleix Pol <***@kde.org> ---
Git commit b446d7e23123c6c50d19f1ec72b5a291229da045 by Aleix Pol.
Committed on 08/11/2018 at 17:18.
Pushed by apol into branch 'master'.

Rename "Settings" back into "Sources"

M +1 -1 discover/qml/DiscoverDrawer.qml
M +3 -4 discover/qml/DiscoverWindow.qml

https://commits.kde.org/discover/b446d7e23123c6c50d19f1ec72b5a291229da045

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

Nate Graham <***@kde.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.15.0

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=389717

--- Comment #4 from Nate Graham <***@kde.org> ---
Git commit c693800980afd0fba86a78bdc84bd951a6eaa6a3 by Nate Graham.
Committed on 10/11/2018 at 03:45.
Pushed by ngraham into branch 'master'.

Use correct name on Sources page itself

M +1 -1 discover/qml/SourcesPage.qml

https://commits.kde.org/discover/c693800980afd0fba86a78bdc84bd951a6eaa6a3