Issue 59285 in chromium: Facebook connect login popup does not close by itself

[c***@googlecode.com]

Comment #10 on issue 59285 by ***@google.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

http://facebook.ubisoft.com/vineyard does not work in Chromium 7.0.532.0

[c***@googlecode.com]

Comment #11 on issue 59285 by ***@google.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

http://facebook.ubisoft.com/vineyard did work for me in Chrome 8.0.552.18
dev

[c***@googlecode.com]

Comment #22 on issue 59285 by edmond.chui: Facebook connect login popup
does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

I followed the instructions to clean up Chrome and installed Chrome dev
channel (version 9.0.587.0 dev) again on two Mac OX X 10.6.4. The same
problem still exists on both Mac.

[c***@googlecode.com]

Comment #26 on issue 59285 by ***@chromium.org: Facebook connect
login popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

From a partner:
"
We determined that blank XD Proxy window after login only occurred when the
Chrome web app was installed. Looking closer, we discovered that the
manifest.json was the culprit. Our url’s section was pointing to our
iframe url http://www.example.com/play/stuff instead of the launch url.
Making them match seemed to fix this problem:

"app": {
"urls": [
"http://www.example.com/play/?game=fun"
],
"launch": {
"web_url": "http://www.example.com/play/?game=fun"
}
},

This could be some cross domain/sandbox type issue.
"

[c***@googlecode.com]

Updates:
Cc: ***@chromium.org ***@chromium.org ***@chromium.org
***@chromium.org
Labels: Feature-Apps

Comment #29 on issue 59285 by ***@chromium.org: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Comment 26 could be important-- is this bug ever observed when the original
page (e.g., mmaprofighter.com, millionairecity.com) is not installed as an
app from the Chrome Web Store? Even in version 9?

There's an explanation if it only happens for apps. The popup window will
switch to a different renderer process when going to a URL outside the
app's manifest, such as Facebook Connect. After a successful login, the
window navigates back to the original app and rejoins the original
process. (You can verify this by looking at the Chrome Task Manager to see
if the page shares a process with the original window or not.)

However, there's a bug in that window.opener is not valid when the
post-login page rejoins the original process. This prevents the page from
telling its parent window that the login succeeded.

Does anyone see this bug if the original page is not installed as an app
from the Chrome Web Store? If so, there's a different problem involved,
because we won't swap processes in that case.

[c***@googlecode.com]

Comment #30 on issue 59285 by ***@chromium.org: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

I've filed issue 65953 for the issue with apps, and I posted a possible
workaround for web developers. If there are cases where this bug occurs
outside of an installed app (on a normal web page), we should investigate
that separately.

[c***@googlecode.com]

Updates:
Status: Fixed

Comment #36 on issue 59285 by ***@chromium.org: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Revision 69338 keeps the login URLs in the app's process so that
window.opener will be valid when the login completes. That should fix the
issue seen here.

I'll track the larger fix for restoring window.opener after a process swap
in issue 65953. Once that's fixed, we can go back to loading the login
URLs in a different process.

[c***@googlecode.com]

Comment #40 on issue 59285 by ***@chromium.org: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Issue 65840 has been merged into this issue.

[c***@googlecode.com]

Comment #44 on issue 59285 by ***@gmail.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Re comment 43:
Yes, I saw that too.
It's extensions related
('Facebook Disconnect' to be specific).

[c***@googlecode.com]

Comment #45 on issue 59285 by ***@chromium.org: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Ah, that sounds like "Facebook Disconnect" is working as intended,
then. :) Just disable the extension if you want to use Facebook Connect.

[c***@googlecode.com]

Comment #46 on issue 59285 by ***@gmail.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

That's what I did.
Now I only have to bear the annoying
Facebook boxes appearing in random sites.
Oh, well.

[c***@googlecode.com]

Comment #67 on issue 59285 by ***@gmail.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

Why is this marked as solved?? It still happens in win7!

[c***@googlecode.com]

Comment #76 on issue 59285 by ***@gmail.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

i get this on http://www.airbnb.com/referrals, even in incognito mode

[c***@googlecode.com]

Comment #77 on issue 59285 by ***@gmail.com: Facebook connect login
popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285

^ should not that's on os x 10.7.2, chrome 15.0.874.121

[c***@googlecode.com]

Comment #81 on issue 59285 by ***@chromium.org: Facebook connect
login popup does not close by itself
http://code.google.com/p/chromium/issues/detail?id=59285#c81

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=114710

------------------------------------------------------------------------
r114710 | ***@chromium.org | Thu Dec 15 14:41:51 PST 2011

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_process_policy.cc?r1=114710&r2=114709&pathrev=114710

Exclude extensions and Chrome Web Store from hosted app process workaround.

BUG=59285
BUG=103263
TEST=Follow a link from a hosted app to an extension or the Chrome Web
Store.

Review URL: http://codereview.chromium.org/8949021
------------------------------------------------------------------------