[chromium-bugs] Issue 488088 in chromium: Replace WebElement::innerText with WebElement::textContent

[c***@googlecode.com]

Status: Assigned
Owner: ***@chromium.org
CC: ***@chromium.org, ***@chromium.org
Labels: Type-Bug Pri-2 Cr-Blink-DOM OS-All

New issue 488088 by ***@chromium.org: Replace WebElement::innerText
with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088

Since Element::innerText is a layout trigger, it's not something we should
be using in the embedder layer:

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/context_menu_params_builder.cc&rcl=1431560023&l=62

Instead, we should be using textContent.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #3 on issue 488088 by ***@chromium.org: Replace
WebElement::innerText with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088#c3

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=195421

------------------------------------------------------------------
r195421 | ***@chromium.org | 2015-05-15T22:25:42.489598Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/WebElement.cpp?r1=195421&r2=195420&pathrev=195421
M
http://src.chromium.org/viewvc/blink/trunk/public/web/WebElement.h?r1=195421&r2=195420&pathrev=195421

Remove WebElement::innerText.

This is the final part 3.

BUG=488088
R=esprehn

Review URL: https://codereview.chromium.org/1137623005
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #4 on issue 488088 by ***@chromium.org: Replace
WebElement::innerText with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088#c4

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=195423

------------------------------------------------------------------
r195423 | ***@chromium.org | 2015-05-15T22:48:52.551594Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/public/web/WebElement.h?r1=195423&r2=195422&pathrev=195423
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/WebElement.cpp?r1=195423&r2=195422&pathrev=195423

Revert of Remove WebElement::innerText. (patchset #1 id:1 of
https://codereview.chromium.org/1137623005/)

Reason for revert:
Broke Android WebView compile:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20%28dbg%29/builds/44894

Post by c***@googlecode.com
Remove WebElement::innerText.
This is the final part 3.
BUG=488088
R=esprehn
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195421

TBR=***@chromium.org,***@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=488088

Review URL: https://codereview.chromium.org/1139603004
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #5 on issue 488088 by ***@chromium.org: Replace
WebElement::innerText with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/f4c7e8044b4a09faa758f629f1a6e8fca2cbe09b

commit f4c7e8044b4a09faa758f629f1a6e8fca2cbe09b
Author: dglazkov <***@chromium.org>
Date: Fri May 15 23:01:59 2015

Remove a few more uses of WebElement::innerText in Chromium.

BUG=488088
R=boliu

Review URL: https://codereview.chromium.org/1140253006

Cr-Commit-Position: refs/heads/master@{#330223}

[modify]
http://crrev.com/f4c7e8044b4a09faa758f629f1a6e8fca2cbe09b/android_webview/renderer/aw_render_view_ext.cc
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Comment #7 on issue 488088 by ***@chromium.org: Replace
WebElement::innerText with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088#c7

The following revision refers to this bug:
http://src.chromium.org/viewvc/blink?view=rev&rev=195452

------------------------------------------------------------------
r195452 | ***@chromium.org | 2015-05-18T07:17:34.109788Z

Changed paths:
M
http://src.chromium.org/viewvc/blink/trunk/Source/web/WebElement.cpp?r1=195452&r2=195451&pathrev=195452
M
http://src.chromium.org/viewvc/blink/trunk/public/web/WebElement.h?r1=195452&r2=195451&pathrev=195452

Constify WebElement::textContent.

This was an omission from my previous expedition.

R=esprehn
BUG=488088

Review URL: https://codereview.chromium.org/1136193003
-----------------------------------------------------------------
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[c***@googlecode.com]

Updates:
Status: Fixed

Comment #8 on issue 488088 by ***@chromium.org: Replace
WebElement::innerText with WebElement::textContent
https://code.google.com/p/chromium/issues/detail?id=488088

(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings