Discussion:
Bug#988398: unblock: aprx/2.9.0+dfsg-3
(too old to reply)
Dave Hibberd
2021-05-11 23:40:01 UTC
Permalink
Package: release.debian.org
Severity: normal
User: ***@packages.debian.org
Usertags: unblock

Please unblock package aprx

[ Reason ]
This is a fix for bug #987332, which impacts a web service the daemon
connects to. Our package installs, enables and starts by default with a
useless config, connecting to their server and doing nothing else.

[ Impact ]
The grave bug outstanding #987332 for the package will remain standing,
the remote service shall continue to see dead connections.

[ Tests ]
This package has been manually tested to ensure new behaviour is as
expected (package exits cleanly on start), and importantly doesn't
cause an update to fail. No autopkgtests have been included as I've not
yet read enough to feel competent at implementing them.

[ Risks ]
This is quite a niche package with 73 Debian users on popcon. Currently, the
default config is causing issue for the service provider it connects to,
and it will continue to if left. The only change to the package is made
to the default configs, commenting out one of the connection details.

[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing

[ Other info ]
Complicating the issue is my relative inexperience with freeze - bundled
into this upload is a Debian janitor bump from dh11->12 that's been on
salsa for a while - I included this in the upload, and it is detailed in
d/changelog, however I didn't want to bring standards or dh any further
up to date than janitor did a year back.

unblock aprx/2.9.0+dfsg-3

-- System Information:
Debian Release: bullseye/sid
APT prefers testing-security
APT policy: (500, 'testing-security'), (500, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-1-amd64 (SMP w/16 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

thx
--
Hibby
MM0RFN
Dave Hibberd
2021-05-12 00:10:01 UTC
Permalink
I should add, as it's probably helpful to, that these changes weren't made in isolation - this was discussed mainly on the debian-hams mailing list https://lists.debian.org/debian-hams/2021/04/msg00019.html and on irc as well.

I also forgot to mention the change in d/rules - this has been included to ensure that the daemon will restart after upgrade, causing installs using an unmodified default config to exit upon start, and disabled on first install to be sure that the service shall only be started once the user is certain they've configured it and they're ready to start it.
--
Hibby
MM0RFN
Debian Bug Tracking System
2021-05-15 12:30:03 UTC
Permalink
tags -1 moreinfo
Bug #988398 [release.debian.org] unblock: aprx/2.9.0+dfsg-3
Added tag(s) moreinfo.
--
988398: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988398
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Sebastian Ramacher
2021-05-15 12:30:04 UTC
Permalink
Control: tags -1 moreinfo
Post by Dave Hibberd
Package: release.debian.org
Severity: normal
Usertags: unblock
Please unblock package aprx
[ Reason ]
This is a fix for bug #987332, which impacts a web service the daemon
connects to. Our package installs, enables and starts by default with a
useless config, connecting to their server and doing nothing else.
[ Impact ]
The grave bug outstanding #987332 for the package will remain standing,
the remote service shall continue to see dead connections.
[ Tests ]
This package has been manually tested to ensure new behaviour is as
expected (package exits cleanly on start), and importantly doesn't
cause an update to fail. No autopkgtests have been included as I've not
yet read enough to feel competent at implementing them.
[ Risks ]
This is quite a niche package with 73 Debian users on popcon. Currently, the
default config is causing issue for the service provider it connects to,
and it will continue to if left. The only change to the package is made
to the default configs, commenting out one of the connection details.
[ Checklist ]
[X] all changes are documented in the d/changelog
[X] I reviewed all changes and I approve them
[X] attach debdiff against the package in testing
[ Other info ]
Complicating the issue is my relative inexperience with freeze - bundled
into this upload is a Debian janitor bump from dh11->12 that's been on
salsa for a while - I included this in the upload, and it is detailed in
d/changelog, however I didn't want to bring standards or dh any further
up to date than janitor did a year back.
debhelper compat changes are not approprtiate for this phase of the
freeze. Please revert that change but make sure that the fix for RC bug
still works as intended.

Cheers
Post by Dave Hibberd
unblock aprx/2.9.0+dfsg-3
Debian Release: bullseye/sid
APT prefers testing-security
APT policy: (500, 'testing-security'), (500, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.10.0-1-amd64 (SMP w/16 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
thx
--
Hibby
MM0RFN
diff -Nru aprx-2.9.0+dfsg/debian/changelog aprx-2.9.0+dfsg/debian/changelog
--- aprx-2.9.0+dfsg/debian/changelog 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/changelog 2021-05-09 23:15:56.000000000 +0100
@@ -1,3 +1,19 @@
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+ [ Dave Hibberd ]
+ * Add debian/gitlab-ci.yml
+ * Change installinit behaviour in debian/rules
+ - aprx is now disabled by default upon install
+ - Belt & Braces interrupting installsystemd too
+ * Added patch to modify default config commenting out default callsign
+ - Closes: #987332
+ [ Debian Janitor]
+ * Use secure URI in debian/watch.
+ * Use secure URI in Homepage field.
+ * Bump debhelper from old 11 to 12.
+ * Update renamed lintian tag names in lintian overrides.
+
+
aprx (2.9.0+dfsg-2) unstable; urgency=medium
* debian/aprx.init
diff -Nru aprx-2.9.0+dfsg/debian/compat aprx-2.9.0+dfsg/debian/compat
--- aprx-2.9.0+dfsg/debian/compat 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/compat 1970-01-01 01:00:00.000000000 +0100
@@ -1 +0,0 @@
-11
diff -Nru aprx-2.9.0+dfsg/debian/control aprx-2.9.0+dfsg/debian/control
--- aprx-2.9.0+dfsg/debian/control 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/control 2020-04-20 18:22:23.000000000 +0100
@@ -3,9 +3,9 @@
Priority: optional
-Build-Depends: debhelper (>= 11)
+Build-Depends: debhelper-compat (= 12)
Standards-Version: 4.2.1
-Homepage: http://thelifeofkenneth.com/aprx/
+Homepage: https://thelifeofkenneth.com/aprx/
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/aprx
Vcs-Git: https://salsa.debian.org/debian-hamradio-team/aprx.git
diff -Nru aprx-2.9.0+dfsg/debian/gitlab-ci.yml aprx-2.9.0+dfsg/debian/gitlab-ci.yml
--- aprx-2.9.0+dfsg/debian/gitlab-ci.yml 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/gitlab-ci.yml 2021-05-09 22:09:08.000000000 +0100
@@ -0,0 +1,6 @@
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+
+ extends: .test-reprotest-diffoscope
diff -Nru aprx-2.9.0+dfsg/debian/NEWS aprx-2.9.0+dfsg/debian/NEWS
--- aprx-2.9.0+dfsg/debian/NEWS 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/NEWS 2021-05-09 23:15:56.000000000 +0100
@@ -0,0 +1,8 @@
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+
+ aprx now ships with NOCALL-1 commented out in the default config, causing
+ the program to exit upon running with default config. Please read the
+ supplied example configs and edit them with your own callsign to avoid
+ spamming the APRS-IS servers, as we have been doing for some time now.
+
diff -Nru aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch
--- aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 2021-05-09 22:04:07.000000000 +0100
@@ -0,0 +1,43 @@
+Description: Patch to prevent default config from connecting to APRS-IS
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987332
+Last-Updated: 2021-05-09
+
+--- a/aprx-complex.conf.in
++++ b/aprx-complex.conf.in
+ # Usable for 99+% of cases.
+ #
+
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
+--- a/aprx-rxigate.conf.in
++++ b/aprx-rxigate.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ <aprsis>
+ #login OTHERCALL-7 # login defaults to $mycall
+--- a/aprx.conf.in
++++ b/aprx.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
diff -Nru aprx-2.9.0+dfsg/debian/patches/series aprx-2.9.0+dfsg/debian/patches/series
--- aprx-2.9.0+dfsg/debian/patches/series 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/series 2021-05-09 21:56:04.000000000 +0100
@@ -1,2 +1,3 @@
+03-Config-callsign.patch
01-man-page.patch
02-reproducible-builds.patch
diff -Nru aprx-2.9.0+dfsg/debian/rules aprx-2.9.0+dfsg/debian/rules
--- aprx-2.9.0+dfsg/debian/rules 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/rules 2021-05-09 23:09:33.000000000 +0100
@@ -31,7 +31,10 @@
rm -vf ./test ./aprx-complex.conf Makefile
- dh_installinit --restart-after-upgrade
+ dh_installinit --restart-after-upgrade --no-enable
+
+ dh_installsystemd --no-enable
dh_installdirs
diff -Nru aprx-2.9.0+dfsg/debian/source/lintian-overrides aprx-2.9.0+dfsg/debian/source/lintian-overrides
--- aprx-2.9.0+dfsg/debian/source/lintian-overrides 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/source/lintian-overrides 2020-04-20 18:22:23.000000000 +0100
@@ -1,2 +1,2 @@
# Upstream does not sign the source, override watch-may-check-gpg-sig warning
-aprx source: debian-watch-may-check-gpg-signature
+aprx source: debian-watch-does-not-check-gpg-signature
diff -Nru aprx-2.9.0+dfsg/debian/watch aprx-2.9.0+dfsg/debian/watch
--- aprx-2.9.0+dfsg/debian/watch 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/watch 2020-04-20 18:22:23.000000000 +0100
@@ -3,5 +3,5 @@
version=4
opts="repack,repacksuffix=+repack,\
dversionmangle=s/(\da?)[\+\.\-~](?:dfsg|debian|ds|repack|repacked)\.?\d*$/$1/" \
-http://thelifeofkenneth.com/aprx/release/ \
+https://thelifeofkenneth.com/aprx/release/ \
(?:|.*/)aprx(?:[_\-]v?|)(\d[^\s/]*)\.(?:tar\.xz|txz|tar\.bz2|tbz2|tar\.gz|tgz)
--
Sebastian Ramacher
Dave Hibberd
2021-05-17 21:10:01 UTC
Permalink
Hi,

Thanks for the feedback.

Attached in aprx-3.diff is my proposed changes to the blocked upload as a new revision - my understanding is now that I've uploaded aprx_2.9.0+dfsg-3, I need to upload aprx_2.9.0+dfsg-4.
This reverts to dh 11 in control and restores the debian-compat file.

I have also attached aprx-2.diff, showing the proposed changes from the current problematic package, aprx_2.9.0+dfsg-2 that is in testing.
This now contains:
* the bug fix
* debian janitor's 2x secure URI fixes,
* gpg signature lintian override
* debian-ci inclusion.

Is my understanding of the next steps (increase package revision) correct?
Are the last 3 items still inappropriate or can I continue to finalise and upload?

Cheers,
--
Hibby
MM0RFN
Post by Sebastian Ramacher
Control: tags -1 moreinfo
debhelper compat changes are not approprtiate for this phase of the
freeze. Please revert that change but make sure that the fix for RC bug
still works as intended.
Cheers
Sebastian Ramacher
2021-05-18 20:20:02 UTC
Permalink
Hi Dave
Post by Dave Hibberd
Hi,
Thanks for the feedback.
Attached in aprx-3.diff is my proposed changes to the blocked upload as a new revision - my understanding is now that I've uploaded aprx_2.9.0+dfsg-3, I need to upload aprx_2.9.0+dfsg-4.
This reverts to dh 11 in control and restores the debian-compat file.
Yes, an upload versioned as -4 is needed. Thanks.

Cheers
Post by Dave Hibberd
I have also attached aprx-2.diff, showing the proposed changes from the current problematic package, aprx_2.9.0+dfsg-2 that is in testing.
* the bug fix
* debian janitor's 2x secure URI fixes,
* gpg signature lintian override
* debian-ci inclusion.
Is my understanding of the next steps (increase package revision) correct?
Are the last 3 items still inappropriate or can I continue to finalise and upload?
Cheers,
--
Hibby
MM0RFN
Post by Sebastian Ramacher
Control: tags -1 moreinfo
debhelper compat changes are not approprtiate for this phase of the
freeze. Please revert that change but make sure that the fix for RC bug
still works as intended.
Cheers
diff -Nru aprx-2.9.0+dfsg/debian/changelog aprx-2.9.0+dfsg/debian/changelog
--- aprx-2.9.0+dfsg/debian/changelog 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/changelog 2021-05-17 21:45:32.000000000 +0100
@@ -1,3 +1,25 @@
+aprx (2.9.0+dfsg-4) UNRELEASED; urgency=medium
+
+ * Revert dh update for freeze
+
+
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+ [ Dave Hibberd ]
+ * Add debian/gitlab-ci.yml
+ * Change installinit behaviour in debian/rules
+ - aprx is now disabled by default upon install
+ - Belt & Braces interrupting installsystemd too
+ * Added patch to modify default config commenting out default callsign
+ - Closes: #987332
+ [ Debian Janitor]
+ * Use secure URI in debian/watch.
+ * Use secure URI in Homepage field.
+ * Bump debhelper from old 11 to 12.
+ * Update renamed lintian tag names in lintian overrides.
+
+
aprx (2.9.0+dfsg-2) unstable; urgency=medium
* debian/aprx.init
diff -Nru aprx-2.9.0+dfsg/debian/control aprx-2.9.0+dfsg/debian/control
--- aprx-2.9.0+dfsg/debian/control 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/control 2021-05-17 21:45:32.000000000 +0100
@@ -5,7 +5,7 @@
Build-Depends: debhelper (>= 11)
Standards-Version: 4.2.1
-Homepage: http://thelifeofkenneth.com/aprx/
+Homepage: https://thelifeofkenneth.com/aprx/
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/aprx
Vcs-Git: https://salsa.debian.org/debian-hamradio-team/aprx.git
diff -Nru aprx-2.9.0+dfsg/debian/gitlab-ci.yml aprx-2.9.0+dfsg/debian/gitlab-ci.yml
--- aprx-2.9.0+dfsg/debian/gitlab-ci.yml 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/gitlab-ci.yml 2021-05-09 22:09:08.000000000 +0100
@@ -0,0 +1,6 @@
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+
+ extends: .test-reprotest-diffoscope
diff -Nru aprx-2.9.0+dfsg/debian/NEWS aprx-2.9.0+dfsg/debian/NEWS
--- aprx-2.9.0+dfsg/debian/NEWS 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/NEWS 2021-05-09 23:21:23.000000000 +0100
@@ -0,0 +1,8 @@
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+
+ aprx now ships with NOCALL-1 commented out in the default config, causing
+ the program to exit upon running with default config. Please read the
+ supplied example configs and edit them with your own callsign to avoid
+ spamming the APRS-IS servers, as we have been doing for some time now.
+
diff -Nru aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch
--- aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 2021-05-09 22:04:07.000000000 +0100
@@ -0,0 +1,43 @@
+Description: Patch to prevent default config from connecting to APRS-IS
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987332
+Last-Updated: 2021-05-09
+
+--- a/aprx-complex.conf.in
++++ b/aprx-complex.conf.in
+ # Usable for 99+% of cases.
+ #
+
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
+--- a/aprx-rxigate.conf.in
++++ b/aprx-rxigate.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ <aprsis>
+ #login OTHERCALL-7 # login defaults to $mycall
+--- a/aprx.conf.in
++++ b/aprx.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
diff -Nru aprx-2.9.0+dfsg/debian/patches/series aprx-2.9.0+dfsg/debian/patches/series
--- aprx-2.9.0+dfsg/debian/patches/series 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/series 2021-05-09 21:56:04.000000000 +0100
@@ -1,2 +1,3 @@
+03-Config-callsign.patch
01-man-page.patch
02-reproducible-builds.patch
diff -Nru aprx-2.9.0+dfsg/debian/rules aprx-2.9.0+dfsg/debian/rules
--- aprx-2.9.0+dfsg/debian/rules 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/rules 2021-05-09 23:09:33.000000000 +0100
@@ -31,7 +31,10 @@
rm -vf ./test ./aprx-complex.conf Makefile
- dh_installinit --restart-after-upgrade
+ dh_installinit --restart-after-upgrade --no-enable
+
+ dh_installsystemd --no-enable
dh_installdirs
diff -Nru aprx-2.9.0+dfsg/debian/source/lintian-overrides aprx-2.9.0+dfsg/debian/source/lintian-overrides
--- aprx-2.9.0+dfsg/debian/source/lintian-overrides 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/source/lintian-overrides 2020-04-20 18:22:23.000000000 +0100
@@ -1,2 +1,2 @@
# Upstream does not sign the source, override watch-may-check-gpg-sig warning
-aprx source: debian-watch-may-check-gpg-signature
+aprx source: debian-watch-does-not-check-gpg-signature
diff -Nru aprx-2.9.0+dfsg/debian/watch aprx-2.9.0+dfsg/debian/watch
--- aprx-2.9.0+dfsg/debian/watch 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/watch 2020-04-20 18:22:23.000000000 +0100
@@ -3,5 +3,5 @@
version=4
opts="repack,repacksuffix=+repack,\
dversionmangle=s/(\da?)[\+\.\-~](?:dfsg|debian|ds|repack|repacked)\.?\d*$/$1/" \
-http://thelifeofkenneth.com/aprx/release/ \
+https://thelifeofkenneth.com/aprx/release/ \
(?:|.*/)aprx(?:[_\-]v?|)(\d[^\s/]*)\.(?:tar\.xz|txz|tar\.bz2|tbz2|tar\.gz|tgz)
diff -Nru aprx-2.9.0+dfsg/debian/changelog aprx-2.9.0+dfsg/debian/changelog
--- aprx-2.9.0+dfsg/debian/changelog 2021-05-09 23:15:56.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/changelog 2021-05-17 21:45:32.000000000 +0100
@@ -1,3 +1,9 @@
+aprx (2.9.0+dfsg-4) UNRELEASED; urgency=medium
+
+ * Revert dh update for freeze
+
+
aprx (2.9.0+dfsg-3) unstable; urgency=medium
[ Dave Hibberd ]
* Add debian/gitlab-ci.yml
diff -Nru aprx-2.9.0+dfsg/debian/compat aprx-2.9.0+dfsg/debian/compat
--- aprx-2.9.0+dfsg/debian/compat 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/compat 2021-05-17 21:43:34.000000000 +0100
@@ -0,0 +1 @@
+11
diff -Nru aprx-2.9.0+dfsg/debian/control aprx-2.9.0+dfsg/debian/control
--- aprx-2.9.0+dfsg/debian/control 2020-04-20 18:22:23.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/control 2021-05-17 21:45:32.000000000 +0100
@@ -3,7 +3,7 @@
Priority: optional
-Build-Depends: debhelper-compat (= 12)
+Build-Depends: debhelper (>= 11)
Standards-Version: 4.2.1
Homepage: https://thelifeofkenneth.com/aprx/
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/aprx
--
Sebastian Ramacher
Dave Hibberd
2021-05-18 23:30:01 UTC
Permalink
aprx 2.9.0+dfsg-4 has been uploaded to unstable, and debdiff with 2.9.0+dfsg-3 has been attached.

Thanks,
--
Hibby
MM0RFN
Post by Sebastian Ramacher
Hi Dave
Post by Dave Hibberd
Hi,
Thanks for the feedback.
Attached in aprx-3.diff is my proposed changes to the blocked upload as a new revision - my understanding is now that I've uploaded aprx_2.9.0+dfsg-3, I need to upload aprx_2.9.0+dfsg-4.
This reverts to dh 11 in control and restores the debian-compat file.
Yes, an upload versioned as -4 is needed. Thanks.
Cheers
Post by Dave Hibberd
I have also attached aprx-2.diff, showing the proposed changes from the current problematic package, aprx_2.9.0+dfsg-2 that is in testing.
* the bug fix
* debian janitor's 2x secure URI fixes,
* gpg signature lintian override
* debian-ci inclusion.
Is my understanding of the next steps (increase package revision) correct?
Are the last 3 items still inappropriate or can I continue to finalise and upload?
Cheers,
--
Hibby
MM0RFN
Post by Sebastian Ramacher
Control: tags -1 moreinfo
debhelper compat changes are not approprtiate for this phase of the
freeze. Please revert that change but make sure that the fix for RC bug
still works as intended.
Cheers
diff -Nru aprx-2.9.0+dfsg/debian/changelog aprx-2.9.0+dfsg/debian/changelog
--- aprx-2.9.0+dfsg/debian/changelog 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/changelog 2021-05-17 21:45:32.000000000 +0100
@@ -1,3 +1,25 @@
+aprx (2.9.0+dfsg-4) UNRELEASED; urgency=medium
+
+ * Revert dh update for freeze
+
+
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+ [ Dave Hibberd ]
+ * Add debian/gitlab-ci.yml
+ * Change installinit behaviour in debian/rules
+ - aprx is now disabled by default upon install
+ - Belt & Braces interrupting installsystemd too
+ * Added patch to modify default config commenting out default callsign
+ - Closes: #987332
+ [ Debian Janitor]
+ * Use secure URI in debian/watch.
+ * Use secure URI in Homepage field.
+ * Bump debhelper from old 11 to 12.
+ * Update renamed lintian tag names in lintian overrides.
+
+
aprx (2.9.0+dfsg-2) unstable; urgency=medium
* debian/aprx.init
diff -Nru aprx-2.9.0+dfsg/debian/control aprx-2.9.0+dfsg/debian/control
--- aprx-2.9.0+dfsg/debian/control 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/control 2021-05-17 21:45:32.000000000 +0100
@@ -5,7 +5,7 @@
Build-Depends: debhelper (>= 11)
Standards-Version: 4.2.1
-Homepage: http://thelifeofkenneth.com/aprx/
+Homepage: https://thelifeofkenneth.com/aprx/
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/aprx
Vcs-Git: https://salsa.debian.org/debian-hamradio-team/aprx.git
diff -Nru aprx-2.9.0+dfsg/debian/gitlab-ci.yml aprx-2.9.0+dfsg/debian/gitlab-ci.yml
--- aprx-2.9.0+dfsg/debian/gitlab-ci.yml 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/gitlab-ci.yml 2021-05-09 22:09:08.000000000 +0100
@@ -0,0 +1,6 @@
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+ - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+
+ extends: .test-reprotest-diffoscope
diff -Nru aprx-2.9.0+dfsg/debian/NEWS aprx-2.9.0+dfsg/debian/NEWS
--- aprx-2.9.0+dfsg/debian/NEWS 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/NEWS 2021-05-09 23:21:23.000000000 +0100
@@ -0,0 +1,8 @@
+aprx (2.9.0+dfsg-3) unstable; urgency=medium
+
+ aprx now ships with NOCALL-1 commented out in the default config, causing
+ the program to exit upon running with default config. Please read the
+ supplied example configs and edit them with your own callsign to avoid
+ spamming the APRS-IS servers, as we have been doing for some time now.
+
diff -Nru aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch
--- aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/03-Config-callsign.patch 2021-05-09 22:04:07.000000000 +0100
@@ -0,0 +1,43 @@
+Description: Patch to prevent default config from connecting to APRS-IS
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=987332
+Last-Updated: 2021-05-09
+
+--- a/aprx-complex.conf.in
++++ b/aprx-complex.conf.in
+ # Usable for 99+% of cases.
+ #
+
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
+--- a/aprx-rxigate.conf.in
++++ b/aprx-rxigate.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ <aprsis>
+ #login OTHERCALL-7 # login defaults to $mycall
+--- a/aprx.conf.in
++++ b/aprx.conf.in
+ # Usable for 99+% of cases.
+ #
+-
+-mycall N0CALL-1
++# Uncomment the below line and add your own callsign
++# mycall N0CALL-1
+
+ #
+ # Global macro for simplified "my location" definition in
diff -Nru aprx-2.9.0+dfsg/debian/patches/series aprx-2.9.0+dfsg/debian/patches/series
--- aprx-2.9.0+dfsg/debian/patches/series 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/patches/series 2021-05-09 21:56:04.000000000 +0100
@@ -1,2 +1,3 @@
+03-Config-callsign.patch
01-man-page.patch
02-reproducible-builds.patch
diff -Nru aprx-2.9.0+dfsg/debian/rules aprx-2.9.0+dfsg/debian/rules
--- aprx-2.9.0+dfsg/debian/rules 2018-09-27 04:20:51.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/rules 2021-05-09 23:09:33.000000000 +0100
@@ -31,7 +31,10 @@
rm -vf ./test ./aprx-complex.conf Makefile
- dh_installinit --restart-after-upgrade
+ dh_installinit --restart-after-upgrade --no-enable
+
+ dh_installsystemd --no-enable
dh_installdirs
diff -Nru aprx-2.9.0+dfsg/debian/source/lintian-overrides aprx-2.9.0+dfsg/debian/source/lintian-overrides
--- aprx-2.9.0+dfsg/debian/source/lintian-overrides 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/source/lintian-overrides 2020-04-20 18:22:23.000000000 +0100
@@ -1,2 +1,2 @@
# Upstream does not sign the source, override watch-may-check-gpg-sig warning
-aprx source: debian-watch-may-check-gpg-signature
+aprx source: debian-watch-does-not-check-gpg-signature
diff -Nru aprx-2.9.0+dfsg/debian/watch aprx-2.9.0+dfsg/debian/watch
--- aprx-2.9.0+dfsg/debian/watch 2017-12-11 17:48:21.000000000 +0000
+++ aprx-2.9.0+dfsg/debian/watch 2020-04-20 18:22:23.000000000 +0100
@@ -3,5 +3,5 @@
version=4
opts="repack,repacksuffix=+repack,\
dversionmangle=s/(\da?)[\+\.\-~](?:dfsg|debian|ds|repack|repacked)\.?\d*$/$1/" \
-http://thelifeofkenneth.com/aprx/release/ \
+https://thelifeofkenneth.com/aprx/release/ \
(?:|.*/)aprx(?:[_\-]v?|)(\d[^\s/]*)\.(?:tar\.xz|txz|tar\.bz2|tbz2|tar\.gz|tgz)
diff -Nru aprx-2.9.0+dfsg/debian/changelog aprx-2.9.0+dfsg/debian/changelog
--- aprx-2.9.0+dfsg/debian/changelog 2021-05-09 23:15:56.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/changelog 2021-05-17 21:45:32.000000000 +0100
@@ -1,3 +1,9 @@
+aprx (2.9.0+dfsg-4) UNRELEASED; urgency=medium
+
+ * Revert dh update for freeze
+
+
aprx (2.9.0+dfsg-3) unstable; urgency=medium
[ Dave Hibberd ]
* Add debian/gitlab-ci.yml
diff -Nru aprx-2.9.0+dfsg/debian/compat aprx-2.9.0+dfsg/debian/compat
--- aprx-2.9.0+dfsg/debian/compat 1970-01-01 01:00:00.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/compat 2021-05-17 21:43:34.000000000 +0100
@@ -0,0 +1 @@
+11
diff -Nru aprx-2.9.0+dfsg/debian/control aprx-2.9.0+dfsg/debian/control
--- aprx-2.9.0+dfsg/debian/control 2020-04-20 18:22:23.000000000 +0100
+++ aprx-2.9.0+dfsg/debian/control 2021-05-17 21:45:32.000000000 +0100
@@ -3,7 +3,7 @@
Priority: optional
-Build-Depends: debhelper-compat (= 12)
+Build-Depends: debhelper (>= 11)
Standards-Version: 4.2.1
Homepage: https://thelifeofkenneth.com/aprx/
Vcs-Browser: https://salsa.debian.org/debian-hamradio-team/aprx
--
Sebastian Ramacher
* signature.asc
Debian Bug Tracking System
2021-05-19 10:40:02 UTC
Permalink
Your message dated Wed, 19 May 2021 10:28:19 +0000
with message-id <E1ljJR5-0000g7-***@respighi.debian.org>
and subject line unblock aprx
has caused the Debian Bug report #988398,
regarding unblock: aprx/2.9.0+dfsg-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ***@bugs.debian.org
immediately.)
--
988398: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=988398
Debian Bug Tracking System
Contact ***@bugs.debian.org with problems
Loading...