[ros-bugs] [jira] (CORE-8969) [dxdiag] content enhancements

[Giannis Adamopoulos (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Giannis Adamopoulos updated CORE-8969:
--------------------------------------

Module: dxdiag
Component/s: Applications

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Bug Zilla
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Assignee: Amine Khaldi (was: Bug Zilla)

Can you please sync the other languages when the patch is ready?

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=66626#comment-66626 ]

Daniel Reimer commented on CORE-8969:
-------------------------------------

Just add the added stuff and size changes etc to the other languages to have the entries in sync. Translating will be the job of others of course ^^

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lee Schroeder updated CORE-8969:
--------------------------------

Attachment: dxdiag_update.patch

Sorry for the wait. It took me a while to sync the other languages too. And please let me know if anything else needs fixing.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=67962#comment-67962 ]

Amine Khaldi commented on CORE-8969:
------------------------------------

{code}PUSHBUTTON "Test DirectMusic", IDC_BUTTON_DISABLEDMUSIC, 370, 145, 80, 14, WS_DISABLED{code} is using {{IDC_BUTTON_DISABLEDMUSIC}} and so is {code}PUSHBUTTON "Disable", IDC_BUTTON_DISABLEDMUSIC, 75, 135, 80, 14, WS_DISABLED{code} rendering the msvc build broken.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lee Schroeder updated CORE-8969:
--------------------------------

Attachment: dxdiag_update.patch

This should fix the build now. I've already compiled it under GCC and it seems to work. Please let me know if you come across any more problems.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68314#comment-68314 ]

Amine Khaldi commented on CORE-8969:
------------------------------------

It still spits tons of warnings and errors. The GCC build is useless when it comes to resource files and also linking. Please use a proper toolchain (the MSVC one) and fix these issues. Cheers.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68315#comment-68315 ]

Daniel Reimer commented on CORE-8969:
-------------------------------------

\reactos\base\applications\dxdiag\lang/fr-FR.rc(176) : warning RC2182 : duplicate dialog control ID 4013
And these are everywhere. Why? Copy paste errors I guess, you use IDC_BUTTON_TESTDSOUND (ID: 4013) three times in all of these files. You need unique defines for anything you use in a resource file and thus the same has to be made for the two added PUSHBUTTON in IDD_NETWORK_DIALOG.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lee Schroeder updated CORE-8969:
--------------------------------

Attachment: dxdiag_update.patch

This should fix the copypasta errors that have been mentioned. And it seems to build alright without any errors or warnings. If there are any more problems with the code, then please let me know so I can try to fix it.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68318#comment-68318 ]

Lee Schroeder commented on CORE-8969:
-------------------------------------

[~aminekhaldi]: Unfortunately, I don't have a copy of MSVC right now.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68319#comment-68319 ]

Amine Khaldi commented on CORE-8969:
------------------------------------

No problem then [~milawynsrealm] I'll just retry and report the issues until all is resolved.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68320#comment-68320 ]

Daniel Reimer commented on CORE-8969:
-------------------------------------

Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices
.Do you wish to continue?".

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68320#comment-68320 ]

Daniel Reimer edited comment on CORE-8969 at 5/30/15 6:09 PM:
--------------------------------------------------------------

Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?".

was (Author: emuandco):
Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices
.Do you wish to continue?".

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68320#comment-68320 ]

Daniel Reimer edited comment on CORE-8969 at 5/30/15 6:11 PM:
--------------------------------------------------------------

Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?".

You already defined it in line 242 and do so again in line 256

was (Author: emuandco):
Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?".

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Daniel Reimer (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68320#comment-68320 ]

Daniel Reimer edited comment on CORE-8969 at 5/30/15 6:12 PM:
--------------------------------------------------------------

Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?".

You already defined it in line 242 and do so again in line 256. Seems to be the last problem we have here

was (Author: emuandco):
Next one.

C:\Users\Daniel\reactos\base\applications\dxdiag\lang/es-ES.rc(256) : error RC2151 : cannot reuse string constants, 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?" already defined. Cannot add 10138(0x279A) - "This will disable all hardware acceleration for DirectDraw on all display devices.Do you wish to continue?".

You already defined it in line 242 and do so again in line 256

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lee Schroeder updated CORE-8969:
--------------------------------

Attachment: dxdiag_update.patch

Fixed. Again, if there are any additional problems, then please let me know.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: WIP
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Labels: PATCH (was: WIP)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi resolved CORE-8969.
--------------------------------

Fix Version/s: 0.4.0
Resolution: Fixed

Committed in r67975. Cheers.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68325#comment-68325 ]

Lee Schroeder commented on CORE-8969:
-------------------------------------

I have noticed recently that the recently submitted code, that in dxdiag.c, some code was removed. I do not remember why I had put it in the patch, nor can I come up with any reason why I would make those changes. Can anyone tell what the removed code does, or if it causes any regressions at all?

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Jared (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68326#comment-68326 ]

Jared commented on CORE-8969:
-----------------------------

Commit 67189put it in there. It was to fix memory leaks.

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68327#comment-68327 ]

Lee Schroeder commented on CORE-8969:
-------------------------------------

I think what happened was that after that failed attempt at restructuring the source tree, all my work up to that point got deleted in the process while trying to deal with that mess. And since the patch that I had initially committed to this ticket (CORE-8969) came before r67189 came along, it didn't put the memory leak fix into consideration, and ended up deleting it when I created the final patch. So, is someone going to fix this, or do you want me to submit another patch?

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Lee Schroeder (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68327#comment-68327 ]

Lee Schroeder edited comment on CORE-8969 at 5/31/15 12:04 AM:
---------------------------------------------------------------

I think what happened was that after that failed attempt at restructuring the source tree, all my work up to that point got deleted in the process while trying to deal with that mess. And since the patch that I had initially committed to this ticket (CORE-8969) was made before r67189 came along, it didn't put the memory leak fix into consideration, and ended up deleting it when I created the final patch. So, is someone going to fix this, or do you want me to submit another patch?

was (Author: milawynsrealm):
I think what happened was that after that failed attempt at restructuring the source tree, all my work up to that point got deleted in the process while trying to deal with that mess. And since the patch that I had initially committed to this ticket (CORE-8969) came before r67189 came along, it didn't put the memory leak fix into consideration, and ended up deleting it when I created the final patch. So, is someone going to fix this, or do you want me to submit another patch?

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Jared (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=68328#comment-68328 ]

Jared commented on CORE-8969:
-----------------------------

I think we should put it back in there since ReactOS has issues with memory management. :)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, dxdiag_update.patch, ROS dxdiag Music.png, ROS dxdiag OS Name.png
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Attachment: (was: dxdiag_update.patch)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: ROS dxdiag Music.png, ROS dxdiag OS Name.png, dxdiag_update.patch
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Attachment: (was: dxdiag_update.patch)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: ROS dxdiag Music.png, ROS dxdiag OS Name.png, dxdiag_update.patch
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Attachment: (was: dxdiag_update.patch)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: ROS dxdiag Music.png, ROS dxdiag OS Name.png, dxdiag_update.patch
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[Amine Khaldi (JIRA)]

[ https://jira.reactos.org/browse/CORE-8969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amine Khaldi updated CORE-8969:
-------------------------------

Attachment: (was: dxdiag_update.patch)

[dxdiag] content enhancements
-----------------------------
Key: CORE-8969
URL: https://jira.reactos.org/browse/CORE-8969
Project: Core ReactOS
Issue Type: Improvement
Components: Applications
Reporter: Lee Schroeder
Assignee: Amine Khaldi
Priority: Minor
Labels: PATCH
Fix For: 0.4.0
Attachments: ROS dxdiag Music.png, ROS dxdiag OS Name.png, dxdiag_update.patch
This improves the content of the tabs that have missing content. Just note that only the English language file has been changed for now.
CHANGELOG
==========
* Some LTEXT controls have been replaced with EDITTEXT controls. This allows the user to copy certain pieces of information without having to: first select "Save All Information", saving the file to a location, open the file in a program like notepad, and then selecting the content.
* Replace the -1 with IDC_STATIC to make the resource files a bit easier to read.
* In the system tab, the name of the operating system is now properly shown.
* In many of the tabs, controls have been added to them to make them a bit more complete. The controls are either disabled or nonfunctional, mostly because we still don't have full DirectX support yet.
And yes, I know that there are still redraw problems (CORE-8734) in this program at the time of writing, but I was able to show these screenshots using a workaround solution of first clicking on the proper tab first, and then dragging the entire window off screen, then on screen again, which somehow drew the contents of the tabs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira