[sane-devel] [janitorial] Debian 9 CI builds added

[Olaf Meeuwissen]

Hi all,

I have been refactoring the way the Docker images for the CI jobs are
built and added support for Debian 9 which was released on 2017-06-17.

At present, the Debian 9 builds only test compilation and flag compiler
warnings. They do not fail the build if there are any warnings, unlike
the builds for Debian 8.

I plan to "stamp out" warnings on *both* Debian versions, in the next
few weeks/months, but feel free to help out ;-)

# BTW, Fedora 26 is also nearing release, with gcc-7 ... curious what
# that'll bring.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2 FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13 F43E B8A4 A88A F84A 2DD9
Support Free Software https://my.fsf.org/donate
Join the Free Software Foundation https://my.fsf.org/join

[Olaf Meeuwissen]

Hi all,

Post by Olaf Meeuwissen
At present, the Debian 9 builds only test compilation and flag compiler
warnings. They do not fail the build if there are any warnings, unlike
the builds for Debian 8.
I plan to "stamp out" warnings on *both* Debian versions, in the next
few weeks/months, but feel free to help out ;-)

An unexpected foot mishap kept me from running on my day off so I went
into "compiler warning fixer bot" mode and fixed most of them. Build
results should be in soon.

# Eh, they finished while writing this mail ...

There are really only two issues left:

- use of the deprecated readdir_r in sanei/sanei_scsi.c

- misleading indentation in the plustek-pp backend

I have fixed a small pile of misleading indentation warnings in other
backends but the mix of indentation "styles" (if you can bring yourself
to call it that) in the plustek-pp source code makes the code just about
impossible to read. I felt a strong urge to just pull the files through
a code beautifier but managed to resist that for now.

@Gerhard> Seeing that git blames you for most of that code, can you
please take a look and fix up at least the trouble spots?
The warnings can be found in the logs of the Debian 9 CI
build pipelines on gitlab[1].

[1] https://gitlab.com/sane-project/backends/pipelines/9333781

The readdir_r warning I'll get to sometime soonish, I hope.

Hope this helps,
--
Olaf Meeuwissen, LPIC-2 FSF Associate Member since 2004-01-27
GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13 F43E B8A4 A88A F84A 2DD9
Support Free Software https://my.fsf.org/donate
Join the Free Software Foundation https://my.fsf.org/join